From f8539e479e4496be7eb5828043a5bec6960c8f6b Mon Sep 17 00:00:00 2001 From: Yannis Vogel Date: Mon, 26 May 2025 18:16:41 +0200 Subject: [PATCH] minor hotfix for db-saving save activity to db *before* mutating it for the target (e.g. save before transforming article into note) --- php/federator/api/v1/newcontent.php | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/php/federator/api/v1/newcontent.php b/php/federator/api/v1/newcontent.php index 124bb87..57a2c14 100644 --- a/php/federator/api/v1/newcontent.php +++ b/php/federator/api/v1/newcontent.php @@ -351,6 +351,11 @@ class NewContent implements \Federator\Api\APIInterface break; case 'Article': + $articleId = $object->getID(); + \Federator\DIO\Posts::deletePost($dbh, $articleId); + // also remove latest saved article-update + \Federator\DIO\Posts::deletePost($dbh, $articleId . '#update'); + // Undo Article (remove article) $idPart = strrchr($recipient->id, '@'); if ($idPart === false) { @@ -366,10 +371,6 @@ class NewContent implements \Federator\Api\APIInterface error_log("NewContent::postForUser Error in Undo Article for recipient $recipient->id, object is not an Article"); } } - $articleId = $object->getID(); - \Federator\DIO\Posts::deletePost($dbh, $articleId); - // also remove latest saved article-update - \Federator\DIO\Posts::deletePost($dbh, $articleId . '#update'); break; } @@ -403,6 +404,8 @@ class NewContent implements \Federator\Api\APIInterface break; case 'Article': + \Federator\DIO\Posts::savePost($dbh, $user->id, $newActivity); + $idPart = strrchr($recipient->id, '@'); if ($idPart === false) { error_log("NewContent::postForUser Error in Create/Update Article. $recipient->id, recipient ID is not valid"); @@ -417,7 +420,6 @@ class NewContent implements \Federator\Api\APIInterface error_log("NewContent::postForUser Error in Create/Update Article for recipient $recipient->id, object is not an Article"); } } - \Federator\DIO\Posts::savePost($dbh, $user->id, $newActivity); break; default: